Avoid using Module.instantiateWasm for pthreads. #22912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing onto #22913 will reveal even more code size savings here. |
sbc100
force-pushed
the
pthread_instantiateWasm
branch
from
0de0f1d to
de86bb9
Compare
|
Now that #22913 we see a bigger codesize saving. |
sbc100
force-pushed
the
pthread_instantiateWasm
branch
from
de86bb9 to
c51a88b
Compare
kripken
approved these changes
Nov 12, 2024
sbc100
force-pushed
the
pthread_instantiateWasm
branch
from
c51a88b to
4f56b57
Compare
This leave the Module.instantiateWasm API for users to overide as they please. Fixes: emscripten-core#22905
sbc100
force-pushed
the
pthread_instantiateWasm
branch
from
4f56b57 to
7f87568
Compare
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
This leave the Module.instantiateWasm API for users to overide as they please. Fixes: emscripten-core#22905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leave the Module.instantiateWasm API for users to overide as they please.
Fixes: #22905