Skip to content

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Mar 26, 2024

After llvm/llvm-project#84137 and #21502, these methods are no longer used.

cc @yamt

@aheejin aheejin requested a review from sbc100 March 26, 2024 06:48
@aheejin aheejin marked this pull request as ready for review March 26, 2024 06:48
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@aheejin aheejin merged commit 29be801 into emscripten-core:main Mar 26, 2024
@aheejin aheejin deleted the remove_old_sjlj_lib branch March 26, 2024 19:43
@yamt
Copy link
Contributor

yamt commented Apr 1, 2024

i thought you wanted to keep older llvm support for a while. isn't it the case?

@sbc100
Copy link
Collaborator

sbc100 commented Apr 1, 2024

No, we only keep that kind of thing around long enough for a new version of llvm to be integrated by out auto-rollers. In general emscripten only support tip-of-tree llvm.

@yamt
Copy link
Contributor

yamt commented Apr 2, 2024

ok. thank you for explanation. how frequently do the auto-rollers run?

@sbc100
Copy link
Collaborator

sbc100 commented Apr 2, 2024

ok. thank you for explanation. how frequently do the auto-rollers run?

They run continuously, which means we normally get several rolls per day.

See https://autoroll.skia.org/r/llvm-project-emscripten-releases

And https://ci.chromium.org/p/emscripten-releases/g/main/console

@yamt
Copy link
Contributor

yamt commented Apr 3, 2024

ok. thank you for explanation. how frequently do the auto-rollers run?

They run continuously, which means we normally get several rolls per day.

See https://autoroll.skia.org/r/llvm-project-emscripten-releases

And https://ci.chromium.org/p/emscripten-releases/g/main/console

ok. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants