[wasm64] Fix emmalloc+verbose under wasm64 #20654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
force-pushed
the
wasm64_emmalloc
branch
3 times, most recently
from
5f657d9 to
beaeb9c
Compare
|
We have some single byte code size wins and some single byte code size losses elsewhere that I think are the just the result of the optimizers seeing slightly different things at different times, but none are significant. |
dschuff
approved these changes
Nov 10, 2023
kripken
reviewed
Nov 11, 2023
sbc100
force-pushed
the
wasm64_emmalloc
branch
4 times, most recently
from
e03b6f2 to
634aa89
Compare
sbc100
force-pushed
the
wasm64_emmalloc
branch
from
634aa89 to
d35431b
Compare
kripken
approved these changes
Nov 13, 2023
kripken
added a commit
that referenced
this pull request
Nov 22, 2023
Take the alignment into account when requesting new memory from the OS. If the alignment is high then we need to ask for enough to ensure we end up aligned, or else we can end up allocating double the memory we need (see #20645). This only changes the amount we allocate from the OS if the alignment is non- standard, that is, this is NFC for normal calls to malloc. Also remove an assertion that limited the maximum alignment. mimalloc wants 4 MB alignment. Fixes #20654
br0nk
pushed a commit
to br0nk/emscripten
that referenced
this pull request
Nov 29, 2023
Take the alignment into account when requesting new memory from the OS. If the alignment is high then we need to ask for enough to ensure we end up aligned, or else we can end up allocating double the memory we need (see emscripten-core#20645). This only changes the amount we allocate from the OS if the alignment is non- standard, that is, this is NFC for normal calls to malloc. Also remove an assertion that limited the maximum alignment. mimalloc wants 4 MB alignment. Fixes emscripten-core#20654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.