Add native wrapper for dbg() JS function
#18619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
native_dbg
branch
7 times, most recently
from
e54cf3b to
d30654f
Compare
tlively
approved these changes
Jan 28, 2023
| printf("hello, world!\n"); | ||
| #ifndef NDEBUG | ||
| // This symbol is only available in debug builds (i.e. -sASSERTIONS) | ||
| _emscripten_dbg("native dbg message"); |
There was a problem hiding this comment.
Should this test _emscripten_dbgf as well?
This means we can remove some complexity from the debug system in `dynlink.c` and other native callers of this function get, for example, the current thread into prepended to the debug message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can remove some complexity from the debug system in
dynlink.cand other native callers of this function get, for example, the current thread into prepended to the debug message.Also, make sure that under node, when threads are enabled we bypass the console and write directly to stderr.