Skip to content

Make more use of ptrToString helper function. NFC #18153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

Make more use of ptrToString helper function. NFC #18153

merged 1 commit into from
Nov 8, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 4, 2022 •
edited
Loading

This change was performed mostly-mechanically with the following vim command:

:%s/0x\(['"]\) + \([^.]*\).toString(16)/\1 + ptrToString(\2)/c

@sbc100 sbc100 requested a review from kripken November 4, 2022 22:16
@sbc100 sbc100 enabled auto-merge (squash) November 4, 2022 22:17
kripken
kripken reviewed Nov 4, 2022
View reviewed changes
@sbc100 sbc100 force-pushed the ptrToString branch 3 times, most recently from b5c5696 to 3abc168 Compare November 5, 2022 00:20
@sbc100 sbc100 requested a review from kripken November 5, 2022 00:33
@sbc100 sbc100 force-pushed the ptrToString branch 2 times, most recently from 0082f15 to df2d20e Compare November 5, 2022 03:49
kripken
kripken reviewed Nov 7, 2022
View reviewed changes
@sbc100 sbc100 force-pushed the ptrToString branch 3 times, most recently from 8ec1baa to 843dec7 Compare November 7, 2022 21:34
@sbc100 sbc100 requested a review from kripken November 8, 2022 00:30
kripken
kripken approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

@sbc100 sbc100 merged commit 29f65fa into main Nov 8, 2022
@sbc100 sbc100 deleted the ptrToString branch November 8, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken