[WasmFS] Implement __syscall_faccessat #16295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Feb 15, 2022
system/lib/wasmfs/syscalls.cpp
Outdated
| return 0; | ||
| } | ||
|
|
||
| long __syscall_access(long path, long amode) { |
There was a problem hiding this comment.
It seems odd that we would want/need to support both of the syscalls...
There was a problem hiding this comment.
I looks like we can/should make PR to remove our definition of __syscall_access so musl will just use __syscall_accessat
|
Ok, after #16296 this is now much simpler. It just:
|
tlively
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
__syscall_faccessat. It is basically the same as the existing__syscall_accessexcept it has two more flags.To get the test passing, also:
FS.chmodFS.mkdirwhich did not receive or sent the mode param to wasm__syscall_fstatat64