Revert musl change to asctime.c. NFC #13973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
revert_musl_asctime_patch
branch
from
dfc533f to
03a615d
Compare
It looks like a patch from a more recent version of musl was applied in #12043. This change reverts that and removes the extra alias needed in in library.js. library.js now implements just a single `__asctime` which is used by both `asctime.c` and `asctime_r.c`. This is in the name doing more without musl matches and less in JS.
sbc100
force-pushed
the
revert_musl_asctime_patch
branch
from
03a615d to
01aad46
Compare
kripken
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a patch from a more recent version of musl was applied
in #12043.
This change reverts that and removes the extra alias needed in in
library.js. library.js now implements just a single
__asctimewhichis used by both
asctime.candasctime_r.c. I've also addedasctime_r.cto the build so that symbol will come from musl now.This is in the name doing more with musl (without patches) and less in JS.