Use more musl code for time to avoid static allocations in JS #12043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
changed the title
kripken
commented
Aug 25, 2020
|
|
||
| char *asctime(const struct tm *tm) | ||
| { | ||
| static char buf[26]; | ||
| return __asctime(tm, buf); | ||
| return __asctime_r(tm, buf); | ||
| } |
There was a problem hiding this comment.
this file is updated to latest upstream musl, the lack of _r was a bug apparently.
btw, this file is basically the same as the other non-reentrant ones - they allocate a buffer, and then call the reentrant version (which we implement in JS).
sbc100
approved these changes
Aug 26, 2020
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
It looks like a patch from a more recent version of musl was applied in #12043. This change reverts that and removes the extra alias needed in in library.js. library.js now implements just a single `__asctime` which is used by both `asctime.c` and `asctime_r.c`. This is in the name doing more without musl matches and less in JS.
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
It looks like a patch from a more recent version of musl was applied in #12043. This change reverts that and removes the extra alias needed in in library.js. library.js now implements just a single `__asctime` which is used by both `asctime.c` and `asctime_r.c`. This is in the name doing more without musl matches and less in JS.
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
It looks like a patch from a more recent version of musl was applied in #12043. This change reverts that and removes the extra alias needed in in library.js. library.js now implements just a single `__asctime` which is used by both `asctime.c` and `asctime_r.c`. This is in the name doing more without musl matches and less in JS.
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
It looks like a patch from a more recent version of musl was applied in #12043. This change reverts that and removes the extra alias needed in in library.js. library.js now implements just a single `__asctime` which is used by both `asctime.c` and `asctime_r.c`. This is in the name doing more without musl matches and less in JS.
sbc100
added a commit
that referenced
this pull request
Jul 20, 2021
Found when auditing untested library functions. This was added as part of #12043 but unlike the other aliases musl does not use `__ctime_r` anywhere so this alias is completely unused.
sbc100
added a commit
that referenced
this pull request
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use musl code for non-reentrant time functions to avoid a static allocation in
JS. Instead, C does the allocation and sends the buffer to the
_rversions of the time functions. This is better for code size too.
Musl calls
__prefixed versions, so add aliases for them.Add a fix from upstream musl to
asctime.c.Add
ctime_randasctime_rto libstandalone, which were missing.Helps WebAssembly/binaryen#3043