Rename internal setting IMPLEMENTED_FUNCTIONS -> WASM_EXPORTS. NFC #13917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of #13873 this settings not also included exported globals so the name stopped making as much sense.
sbc100
force-pushed
the
rename_IMPLEMENTED_FUNCTIONS
branch
from
2e61f07 to
cdb4098
Compare
dschuff
approved these changes
Apr 16, 2021
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
I guess at this point ld is done, so there is no symbol table anywhere, so there a 1:1 relationship between defined symbols (that would be in a symbol table) and exported functions and named globals?
Collaborator
Author
Yup. Pretty much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #13873 this settings not also included exported globals
so the name stopped making as much sense.