Skip to content

Feedback from #13873 #13916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Feedback from #13873 #13916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Current Trunk
`EXPORTED_RUNTIME_METHODS`.
- When building with `MAIN_MODULE=2` the linker will now automatically include
any symbols required by side modules found on the command line. This means
that for many users of `MAIN_MODULE=2` it should not longer be necessary to
that for many users of `MAIN_MODULE=2` it should no longer be necessary to
list explicit `EXPORTED_FUNCTIONS`. Also, users of `MAIN_MODULE=1` with
dynamic linking (not dlopen) who list all side modules on the command line,
should be able to switch to `MAIN_MODULE=2` and get a reduction in code size.
Expand Down
4 changes: 3 additions & 1 deletion tools/webassembly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@

HEADER_SIZE = 8

LIMITS_HAS_MAX = 0x1


def toLEB(num):
return leb128.u.encode(num)
Expand Down Expand Up @@ -164,7 +166,7 @@ def readLimits(self):
flags = self.readByte()
initial = self.readULEB()
maximum = 0
if flags & 0x1:
if flags & LIMITS_HAS_MAX:
maximum = self.readULEB()
return Limits(flags, initial, maximum)

Expand Down