Restore orginal file layout for musl and libcxx. NFC. #13154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
move_headers
branch
2 times, most recently
from
466b521 to
b45ebad
Compare
sbc100
force-pushed
the
use_sysroot
branch
2 times, most recently
from
0fbd5b1 to
4bda788
Compare
sbc100
force-pushed
the
use_sysroot
branch
4 times, most recently
from
356b56d to
647e638
Compare
Now that we build the sysroot, including the header tree programatically we can restore the original layout of the musl and libcxx directories. This will make future updates and comparisons with upstream easier.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 20, 2023
libcxx has direct support for `_NEWLIB_VERSION` in `__locale` so just use that. This libcxx support was added in http://reviews.llvm.org/D7888 and landed in emscripten in emscripten-core#13154.
sbc100
added a commit
that referenced
this pull request
Dec 20, 2023
libcxx has direct support for `_NEWLIB_VERSION` in `__locale` so just use that. This libcxx support was added in http://reviews.llvm.org/D7888 and landed in emscripten in #13154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we build the sysroot, including the header tree programatically
we can restore the original layout of the musl and libcxx directories.
This will make future updates and comparisons with upstream easier.
This is a followup to #13090