Skip to content

Convert deps_info to python so it can include comments #12847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

Convert deps_info to python so it can include comments #12847

merged 1 commit into from
Nov 25, 2020

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 20, 2020

Since there was only a single consumer in python it also
makes no sense to keep it in JSON format.

@sbc100 sbc100 requested a review from kripken November 20, 2020 21:50
@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 20, 2020

turns out we had bunch of duplicate entries in there!

$ flake8 tools/
tools/deps_info.py:161:3: F601 dictionary key '_embind_register_std_string' repeated with different values
tools/deps_info.py:162:3: F601 dictionary key '_embind_register_std_wstring' repeated with different values
tools/deps_info.py:166:3: F601 dictionary key '_embind_register_std_string' repeated with different values
tools/deps_info.py:167:3: F601 dictionary key '_embind_register_std_wstring' repeated with different values
tools/deps_info.py:188:3: F601 dictionary key 'emscripten_set_mousemove_callback_on_thread' repeated with different values
tools/deps_info.py:189:3: F601 dictionary key 'emscripten_set_mousemove_callback_on_thread' repeated with different values

!!

@sbc100 sbc100 force-pushed the rename_deps_info branch 3 times, most recently from 97efbc4 to a861fbf Compare November 23, 2020 01:45
@curiousdannii
Copy link
Contributor

Do you want to take the opportunity to sort them?

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 24, 2020

ping

@sbc100
Convert deps_info to python so it can include comments
af02d5f 
Since there was only a single consumer in python it also
makes no sense to keep it in JSON format.
@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 25, 2020

ping

kripken
kripken approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check, but I assume the actual deps are all unchanged?

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 25, 2020

Yes, unchanged.

@sbc100 sbc100 merged commit 201e048 into master Nov 25, 2020
@sbc100 sbc100 deleted the rename_deps_info branch November 25, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @curiousdannii @kripken