Skip to content

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 17, 2020

We have no tests for this code and it seems to relate to
firefox OS which I believe is not longer a thing.

Fixes: #12800

We have no tests for this code and it seems to relate to
firefox OS which I believe is not longer a thing.

Fixes: #12800
@sbc100 sbc100 requested a review from juj November 17, 2020 18:47
@sbc100 sbc100 requested a review from kripken November 17, 2020 18:48
@kripken
Copy link
Member

kripken commented Nov 17, 2020

firefox OS which I believe is not longer a thing.

https://en.wikipedia.org/wiki/KaiOS ?

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But lgtm to remove this, I doubt anyone is using it. We can always restore it if someone files an issue.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 17, 2020

I'll give @juj a day or two speak up for this file before removing it :)

@juj
Copy link
Collaborator

juj commented Nov 17, 2020

lgtm.

@sbc100 sbc100 merged commit 47dc32a into master Nov 17, 2020
@sbc100 sbc100 deleted the remove_ffdb branch November 17, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

old python syntax in tools/ffdb.py
3 participants