Skip to content

Move static allocation for fetch queue from JS to C++ code #12049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 26, 2020

This moves the function emscripten_get_fetch_queue and its static
allocation in the native code avoiding the runtime allocation on the JS side.

See: #12040

This avoids the runtime allocation on the JS side.

See: #12040
@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 26, 2020

Should we wait for @juj to weigh in? This seems like a pretty straight forward transformation, but I could be missing something subtle.

@kripken feel free to land if you need to change for your work.

@kripken
Copy link
Member

kripken commented Aug 26, 2020

It would be good to get @juj's feedback, but I think this is good to land whenever you want. Seems simple and correct to me, passes tests, and in the worst case we can revert it later (easily I think, since there is no stack of changes expected to land on top of these files AFAIK).

(I don't need this urgently myself, but it's a great change.)

@sbc100 sbc100 merged commit d7ef8f3 into master Aug 28, 2020
@sbc100 sbc100 deleted the static_fetch_data branch August 28, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants