Simplify EM_ASM handling #11972
Merged
Simplify EM_ASM handling #11972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Aug 20, 2020
| return window.almost_PI; | ||
| }); | ||
| printf("almost PI: %f\n", almost_PI); | ||
| assert(fabs(almost_PI - 3.14159) < 0.001); |
There was a problem hiding this comment.
What the changes to the test code?
There was a problem hiding this comment.
Just some added testing. We tested MAIN_THREAD_EM_ASM_INT but not _DOUBLE.
| @@ -4186,12 +4229,6 @@ LibraryManager.library = { | |||
| llvm_dbg_value: function() {}, | |||
| llvm_debugtrap: function() {}, | |||
| llvm_ctlz_i32: function() {}, | |||
| emscripten_asm_const: function() {}, | |||
There was a problem hiding this comment.
This function no longer exists? I guess it was never needed?
There was a problem hiding this comment.
Yes, it may have made sense in some old approach to EM_ASM in fastcomp perhaps.
sbc100
added a commit
that referenced
this pull request
Jul 12, 2023
Loosk like its usage was removed in #11972.
sbc100
added a commit
that referenced
this pull request
Jul 12, 2023
Loosk like its usage was removed in #11972.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emscripten counterpart to WebAssembly/binaryen#3044 , see background there,
and WebAssembly/binaryen#3043
This basically gets rid of the special handling of EM_ASMs. Instead, they are just
normal JS library methods like any other.
(The one interesting thing in them, unchanged from before this PR, is that we
need to read the varargs before doing any proxying, see the comment there for
more details.)