Skip to content

Error on use of fastcomp #11831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Error on use of fastcomp #11831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51c128e
Error on use of fastcomp
sbc100 Aug 7, 2020
55adecb
Update emcc.py
sbc100 Aug 7, 2020
a653679
Update emcc.py
sbc100 Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ executors:
EMCC_CORES: "4"
EMSDK_NOTTY: "1"
PYTHON_BIN: "python3"
EMCC_ALLOW_FASTCOMP: "1"
mac:
environment:
EMSDK_NOTTY: "1"
Expand Down
7 changes: 4 additions & 3 deletions emcc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,10 +1278,11 @@ def get_last_setting_change(setting):
# we also do not support standalone mode in fastcomp.
shared.Settings.STANDALONE_WASM = 1

# We allow this warning to be supressed by the environment so that we can run the test
# suite against fastcomp while supressing this warning.
# We allow this error to be supressed by the environment so that we can run the test
# suite against fastcomp for the time being.
# See: https://github.com/emscripten-core/emscripten/issues/11319
if not shared.Settings.WASM_BACKEND and 'EMCC_ALLOW_FASTCOMP' not in os.environ:
diagnostics.warning('fastcomp', 'the fastomp compiler is deprecated. Please switch to the upstream llvm backend as soon as possible and open issues if you have trouble doing so')
exit_with_error('the fastcomp compiler is no longer available in emscripten. Please use the upstream llvm backend or use an older (< 2.0.0) version of emscripten.')

if options.no_entry or ('_main' not in shared.Settings.EXPORTED_FUNCTIONS and
'__start' not in shared.Settings.EXPORTED_FUNCTIONS):
Expand Down