embind: fix asan violation in std::string and std::wstring #11599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASAN strictly forbids read over allocated boundary, so length checking should go before `\0` testing. Fixes #11598.
|
Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS. |
|
Looks great to me.. @kripken what do you think? |
jgravelle-google
approved these changes
Jul 9, 2020
|
Oh, should probably re-enable the |
|
Great PR, thank you @jiulongw ! 😄 And yes, this might allow the asan test to work now for embind, I'll open a PR to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASAN strictly forbids read over allocated boundary, so length checking
should go before
\0testing.Fixes #11598.