Remove emterpreter support. #11020
Merged
Remove emterpreter support. #11020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_emterpreter
branch
from
d51e0aa to
b76a478
Compare
kripken
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
No.... all my beautiful code... Heh, just kidding, but I do have fond memories of some of the deleted stuff here. I guess it will live in git forever...
Please also search for "Emterpreter" (case-insensitive) under site/source as I see mentions in e.g. site/source/docs/optimizing/Optimizing-Code.rst
sbc100
added a commit
that referenced
this pull request
Apr 28, 2020
Seems like a good first step before #11020.
sbc100
added a commit
that referenced
this pull request
Apr 28, 2020
Seems like a good first step before #11020.
sbc100
added a commit
that referenced
this pull request
Apr 29, 2020
Seems like a good first step before #11020.
sbc100
force-pushed
the
remove_emterpreter
branch
4 times, most recently
from
58e713e to
1b2914e
Compare
|
I did end up having to disable all of the async browser tests.. which I guess makes sense. Landing this will allow us to remove the swappable module support which in turn helps me to land: |
sbc100
added a commit
that referenced
this pull request
May 6, 2020
For the wasm backend we stopped supporting this correctly back in #9922. This change means that the top level bindings and the `Module` bindings for were bound on first use. This works fro wasm async compilation but not for replacign running modules. The only other use was emterpretify which is due to be removed soon in any case: #11020 We may want to bring back full support for this later, but for now we don't support it correctly so better to remove it.
kripken
approved these changes
May 7, 2020
sbc100
added a commit
that referenced
this pull request
May 7, 2020
For the wasm backend we stopped supporting this correctly back in #9922. This change means that the top level bindings and the `Module` bindings for were bound on first use. This works fro wasm async compilation but not for replacign running modules. The only other use was emterpretify which is due to be removed soon in any case: #11020 We may want to bring back full support for this later, but for now we don't support it correctly so better to remove it.
sbc100
force-pushed
the
remove_emterpreter
branch
2 times, most recently
from
8e3245b to
7818013
Compare
sbc100
force-pushed
the
remove_emterpreter
branch
3 times, most recently
from
2e94ce5 to
756fc5e
Compare
Emterpreter has largerly been replaces by asyncify and is fastcomp only so due for removing in the near future anyway. The reason I'm pulling this forward ahead of fastcomp deprecation is that it unblocks some other refactoring I'm working on.
sbc100
force-pushed
the
remove_emterpreter
branch
from
72890fb to
533ce49
Compare
sbc100
added a commit
that referenced
this pull request
Jan 22, 2021
This looks like it was only used by EMTERPRETIFY_ASYNC which was removed in #11020.
sbc100
added a commit
that referenced
this pull request
Jan 22, 2021
This looks like it was only used by EMTERPRETIFY_ASYNC which was removed in #11020.
sbc100
added a commit
that referenced
this pull request
Jan 22, 2021
This looks like it was only used by EMTERPRETIFY_ASYNC which was removed in #11020.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emterpreter has largerly been replaces by asyncify and is fastcomp only
so due for removing in the near future anyway.
The reason I'm pulling this forward ahead of fastcomp deprecation
is that it unblocks some other refactoring I'm working on.