Skip to content

[RFC#236] Deprecate String prototype extensions #19234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2020
Merged

[RFC#236] Deprecate String prototype extensions #19234

merged 4 commits into from
Nov 11, 2020

Conversation

@locks
Copy link
Contributor

@locks locks commented Oct 27, 2020 •
edited
Loading

Part of emberjs/rfc-tracking#26.
PR twin of ember-learn/deprecation-app#696.

This PR deprecate using the String.prototype extension version of @ember/string methods.
Calling "Tomster and Zoey".underscore() will throw a deprecation error.

I did not apply the wrapper method to loc as that is completely deprecated and has its own id.

@locks locks changed the title deprecate String prototype extensions [RFC#236] Deprecate String prototype extensions Oct 27, 2020
@locks locks mentioned this pull request Oct 27, 2020
Closed
17 tasks
@locks locks force-pushed the deprecate-ember-string-prototype-extension branch from e94b9bf to f22a636 Compare October 27, 2020 11:34
@locks locks mentioned this pull request Oct 27, 2020
Merged
2 tasks
@locks locks force-pushed the deprecate-ember-string-prototype-extension branch from f22a636 to ec07cdc Compare October 27, 2020 11:43
rwjblue
rwjblue requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to wrap the prototype extension tests in expectDeprecation

@locks locks force-pushed the deprecate-ember-string-prototype-extension branch from c29007e to 6e1c963 Compare October 27, 2020 13:34
@locks locks requested a review from rwjblue November 10, 2020 02:40
@rwjblue rwjblue merged commit d2ba6c0 into master Nov 11, 2020
@rwjblue rwjblue deleted the deprecate-ember-string-prototype-extension branch November 11, 2020 15:44
@locks locks mentioned this pull request Jan 5, 2021
Merged
@jamescdavis jamescdavis mentioned this pull request Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@locks @rwjblue