Skip to content

Conversation

chadhietala
Copy link
Contributor

This supersedes #13199

@chadhietala
Copy link
Contributor Author

@chancancode @wycats r+?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ should render other templates registered with the container

@chancancode
Copy link
Member

@chadhietala looks great to me other than two missing assertions!

As a follow-up to this (you can send it as a separate PR if you prefer), can you add some tests to confirm whether we support accessing the "local variables" in the current scope inside a partial?

e.g. {{#with foo as |bar|}}{{partial "triesToUseBarInThePartial}}{{/with}} or {{#each foo as |bar|}}{{partial "triesToUseBarInThePartial}}{{/with}}

@chadhietala
Copy link
Contributor Author

@chancancode Can you kick the sauce labs? Seems to have failed for unrelated reasons?

@chancancode
Copy link
Member

🏃 kicked

@chancancode chancancode merged commit dd3eb14 into emberjs:master Apr 12, 2016
@chancancode
Copy link
Member

Thank you @chadhietala and @jheth!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants