[Glimmer2] Migrate bindings integration test #13210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This just straight up doesn't work for HTMLBars but does for glimmer. Must be something with the way I updated the view semantics. Test output was two way: , string:
|
☔ The latest upstream changes (presumably #13195) made this pull request unmergeable. Please resolve the merge conflicts. |
Joelkang
force-pushed
the
binding-integration-tests
branch
from
0594257 to
8344359
Compare
|
Sorry for the delay. Just two quick comment, looks great otherwise! If you can't get to those by the end of day, I can probably just do it for you! |
|
Doing it now, gimme a few mintutes |
Joelkang
force-pushed
the
binding-integration-tests
branch
from
8344359 to
32d83e9
Compare
|
@chancancode updated and squashed! |
Joelkang
changed the title
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13127.
Migrated the undefined dynamic path test. Kept the binding and re-binding tests. Everything else is tested elsewhere.