[Glimmer2] Migrate and Remove block params test #13189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
There was a problem hiding this comment.
We've been using the strip helper to keep things readable. It removes all leading whitespace and newlines. For example, check out https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/tests/integration/syntax/each-in-test.js#L110-L116.
|
Thanks @Joelkang! Looks good to me. |
|
☔ The latest upstream changes (presumably #13190) made this pull request unmergeable. Please resolve the merge conflicts. |
Joelkang
force-pushed
the
block-params-test
branch
from
e7624e4 to
943d12c
Compare
|
Rebased, squashed and added the an R in INUR for the infinite loop test |
|
@Joelkang looks like we lost the removals from the rebase 😄 |
…ly-components and with-test
Joelkang
force-pushed
the
block-params-test
branch
from
943d12c to
4737b98
Compare
|
herp derp. fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
should raise error if helper not available: custom-helpers-test.js:287 already tests thisRemove
basic block params usage: syntax/with-test.js:21 already tests thisKeeping
components can yield values: Even though helpers/hash-test.js already tests yielding hashes, I added a test to components/curly-components.js to test yielding non-hash propertiesPart of #13127
cc @chancancode