Glimmer dynamic components (component helpers) #13057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are copied from the (new) curly component tests. The first test case has been split to test the dynamic component switching, but this is otherwise just a straight port of the existing tests (which is itself not the complete set of components tests we have). As usual, we need to come back and port the rest of the tests. The foundation for this feature is exhaustively matrix-tested in Glimmer, including the component switch scenario.
52 tasks
chancancode
added a commit
that referenced
this pull request
Mar 6, 2016
Glimmer dynamic components (component helpers)
26 tasks
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are copied from the (new) curly component tests. The first test case has been split to test the dynamic component switching, but this is otherwise just a straight port of the existing tests (which is itself not the complete set of components tests we have).
As usual, we need to come back and port the rest of the tests.
The foundation for this feature is exhaustively matrix-tested in Glimmer, including the component switch scenario.