Skip to content

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Nov 19, 2022

  • Inline filter-params mixin into its only user
  • Replace parent-name mixin with simple getter and util

@chriskrycho chriskrycho marked this pull request as ready for review November 19, 2022 17:25
@chriskrycho
Copy link
Contributor Author

Not sure why Percy failed here, either. 🤔 Trying the "merge in master and see if that helps" dance.

@chriskrycho
Copy link
Contributor Author

All right, since the last commit here was the one which changed the FastBoot-related behavior, I've dropped that one and will try to take a further swing at it on a different PR; I also extracted what was accidentally the first commit here and extracted it to #830.

@chriskrycho chriskrycho merged commit 99f04d8 into master Nov 19, 2022
@chriskrycho chriskrycho deleted the demixinify branch November 19, 2022 22:42
@chriskrycho
Copy link
Contributor Author

There we go. I'll tackle the transitionTo and the last mixin separately!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant