Skip to content

Feature/fix md linter #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Oct 4, 2018

@jenweber This PR fixes remaining linter warnings. I had to add images as well to fix warnings, that being said, we probably need to update this screenshots as they look unfashionably outdated.

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

@locks
Copy link
Contributor

locks commented Oct 4, 2018

@aklkv are you able to take new screenshots?

@locks locks merged commit e4c22ec into ember-learn:master Oct 4, 2018
@aklkv
Copy link
Contributor Author

aklkv commented Oct 4, 2018

@locks sorry I am on mac computer :) I can sip up VM but I will take some time tho, it might be easier to ask some one with windows machine

@aklkv aklkv deleted the feature/fix-md-linter branch October 4, 2018 08:34
@jenweber
Copy link
Contributor

jenweber commented Oct 4, 2018

New images are in PR #16 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants