fix(fontlock): fontify parameters in multiline arglist #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuco1
force-pushed
the
fix/multiline-param-list
branch
from
e0875a2 to
fc6a63e
Compare
|
Hey. Seems like we’re still missing some test-cases for the new syntax highlighting you’re adding support for here. Let me know when you think this is ready for review! |
Fuco1
force-pushed
the
fix/multiline-param-list
branch
from
fc6a63e to
218a546
Compare
|
I added more test cases and also removed the |
|
Simplifications are always welcome. And especially with more tests. Consider it merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the anchored matcher to allow for multi-line arg list. I will add tests if we decide to go forward with this change.
Before
after