Suppress obsolete warning on latest emacs #4859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emacs HEAD has obsoleted `revert-buffer-in-progress-p`: https://github.com/emacs-mirror/emacs/commit/ 1fc4bb1fead205e425f69fa803a71f4e446d48a8 We can't use the new name because it doesn't exist on older emacs versions, so just ignore the warning for now.
|
I don't love the random warning suppressions in two different places. The best other option I came up with was sprinkling Maybe conditionally doing a |
And now we no longer need to suppress the warning
|
Okay, I like that better after all. |
|
The link doesn't seem to point to the relevant commit. 🤔 https://github.com/emacs-mirror/emacs/commit/ |
jcs090218
approved these changes
Aug 21, 2025
Whoops, the link got line-broken somehow. Should work now -- emacs-mirror/emacs@1fc4bb1 |
jcs090218
approved these changes
Aug 22, 2025
jcs090218
approved these changes
Aug 22, 2025
jcs090218
approved these changes
Aug 22, 2025
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs HEAD has obsoleted
revert-buffer-in-progress-p: emacs-mirror/emacs@1fc4bb1We can't use the new name because it doesn't exist on older emacs versions, so just ignore the warning for now.