-
-
Notifications
You must be signed in to change notification settings - Fork 950
feat: added odin language support through ols #4818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For the record, there is a fork from original odin-mode at https://git.sr.ht/~mgmarlow/odin-mode. |
|
Hmmm... I am not sure why the CI fails. 🤔 |
Same, I haven't touched anything in the clangd server. And the 2 previous commits passed all the checks. When I make compile locally it is all fine but as I stated I'm on Windows. I just checked using wsl and it is also fine. I don't have an arm machine 🤔 |
|
The problem is the (defcustom lsp-odin-ols-binary-path
(f-join lsp-odin-ols-server-install-dir "latest"
;; ERROR, this cond returns `nil'!
(cond ((eq system-type 'windows-nt)
"ols-x86_64-pc-windows-msvc.exe")
((eq system-type 'darwin)
(if (string-match "aarch64-.*" system-configuration)
"ols-arm64-darwin"
"ols-x86_64-darwin"))
((and (eq system-type 'gnu/linux)
(or (eq (string-match "^x86_64" system-configuration) 0)
(eq (string-match "^i[3-6]86" system-configuration) 0)))
"ols-x86_64-unknown-linux-gnu")))
"The path where ols binary after will be stored."
:group 'lsp-odin-ols
:type 'file)The |
made the cond a pcase and gave a defulat of the linux versions
right, got it. I switched over to a pcase statement defaulting to the linux versions |
|
Awesome! Thank you for your cooperation! ;) |
Added odin language support though the ols server by Daniel Gavin
This will automatically install the server based on the nightly release provided by the repository and should work for all platforms. I have only been able to test on Windows but I have included the binary names for mac os (x86 and arm) and also the linux binary.
A user should install either odin-mode (this hasn't seen active development for the last 2 years and the maintainer seems to have abandoned it) or odin-ts-mode (still in development)