changed: lsp-haskell-completion-snippets-on default: t -> lsp-enable-… #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snippet If lsp-enable-snippet is disabled, snippet generation will be useless, so it is preferable to turn it off. I also had a long time trouble with setting this option to nil on lsp-haskell without disabling the snippet. It's good to provide a variable ledge for such users.
|
What happens if An alternative would be that where we actually use this variable, we could instead pass |
|
No, I do not receive any error. Also, if anything, the aim of this PR is to prevent users from being confused when they try to disable snippets. |
|
I mean users shouldn't be confused since they won't see anything untoward happening. Still, this seems safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…snippet
If lsp-enable-snippet is disabled, snippet generation will be useless, so it is preferable to turn it off.
I also had a long time trouble with setting this option to nil on lsp-haskell without disabling the snippet.
It's good to provide a variable ledge for such users.