Adding before_disconnect hook #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwaffles
reviewed
Nov 2, 2023
warmwaffles
reviewed
Nov 2, 2023
Co-authored-by: Matthew Johnston <[email protected]>
|
<3 for prompt feedback |
warmwaffles
approved these changes
Nov 2, 2023
|
@jeregrine I'll be cutting a release for this soon. |
|
@warmwaffles no rush here <3 thanks |
|
This will be released under |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful with some extensions like cr-sqlite that require a cleanup setup before disconnect/close, which is not un-common.
I thought maybe this would work in db_connection but I don't know if its general enough for ALL db connections and ahh touching that state machine is the worst.