Skip to content

Use Connection.connect instead of Sqlite3.open for storage_up #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2022
Merged

Use Connection.connect instead of Sqlite3.open for storage_up #96

merged 1 commit into from
Dec 21, 2022

Conversation

philipgiuliani
Copy link
Contributor

By using the Connection.connect function with all properties, we make sure that the database is created as encrypted DB if the key option is present.

I was unsure about using the Exqlite.Connection.disconnect or the Exqlite.Sqlite3.close function.

Closes elixir-sqlite/exqlite#207

@philipgiuliani philipgiuliani changed the title Use Connection.connect instead of Sqlite3.open Use Connection.connect instead of Sqlite3.open for storage_up Dec 21, 2022
warmwaffles
warmwaffles approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@warmwaffles warmwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ask why inline the helper method, but it makes sense. You want to pass the original options into the connect function.

@warmwaffles warmwaffles merged commit 547ed72 into elixir-sqlite:main Dec 21, 2022
@warmwaffles
Copy link
Member

@philipgiuliani released under v0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmwaffles warmwaffles warmwaffles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mix ecto.migrate creates an encrypted db, mix ecto.create doesn't
2 participants
@philipgiuliani @warmwaffles