Allow to configure whether all errors should be logged #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkgil
commented
Apr 22, 2021
lib/plug/cowboy.ex
Outdated
| When using a Unix socket, OTP 21+ is required for `Plug.Static` and | ||
| `Plug.Conn.send_file/3` to behave correctly. | ||
| ## Application configuration |
There was a problem hiding this comment.
Is that the right place for these docs? Let me know if I should move it.
arkgil
commented
Apr 22, 2021
test/plug/cowboy/translator_test.exs
Outdated
Comment on lines
60
to
61
| Application.put_env(:plug_cowboy, :log_all, true) | ||
| on_exit(fn -> Application.delete_env(:plug_cowboy, :log_all) end) |
There was a problem hiding this comment.
The test suite is not async so this should be fine.
josevalim
reviewed
Apr 22, 2021
lib/plug/cowboy.ex
Outdated
| ## Application configuration | ||
| * `:log_all` - A boolean that determines whether all exceptions are logged by the adapter. |
There was a problem hiding this comment.
What if we call it log_exceptions_with_status_code_from which defaults to 500? This way people can opt-in to 400 but still leave others out.
There was a problem hiding this comment.
What if we stretched this and allowed a range or a list? E.g. if I wanted to skip logging 415.
There was a problem hiding this comment.
log_exceptions_with_status_code that expects a list of ranges work for me.
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration is done via application env, since there is no way to pass options to Logger translators. I called the option
log_all, but it might be limiting if you'd like to expand this to allow more fine-grained filtering in the future.Closes #67