Skip to content

Validate type of :deps_paths option for formatter_for_file/2 #14669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Validate type of :deps_paths option for formatter_for_file/2 #14669

merged 1 commit into from
Jul 24, 2025

Conversation

giddie
Copy link
Contributor

@giddie giddie commented Jul 24, 2025

I ran into an issue caused by a typo when passing :deps_paths:

Mix.Tasks.Format.formatter_for_file(file_path, deps_paths: Mix.Project.deps_path())
# Should have been:
Mix.Tasks.Format.formatter_for_file(file_path, deps_paths: Mix.Project.deps_paths())

Notice the missing "s". The result was a message about missing dependencies, and in combination with the subtle typo, it took some time to figure out what was going wrong here. The additional check should make this kind of issue much clearer.

@josevalim josevalim merged commit 4fc85f3 into elixir-lang:main Jul 24, 2025
13 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

josevalim pushed a commit that referenced this pull request Jul 26, 2025
@giddie @josevalim
Validate type of :deps_paths option for formatter_for_file/2 (#14669)
2308be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giddie @josevalim