Don't import private function name from router #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underscored functions are never imported by default.
crbelaus
changed the title
odarriba
requested changes
Sep 10, 2024
Contributor
odarriba
left a comment
odarriba
left a comment
There was a problem hiding this comment.
Added a comment of a required change to be able to call the parse_options function which is no longer imported
Co-authored-by: Óscar de Arriba <[email protected]>
odarriba
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underscored functions are never imported by default. This should fix #90.
If you import the router on
mainyou will see that theparse_optionsfunction is imported automatically:If you do the same now you will se that the function is not imported and it tries to find it in the Kernel module.