Module name isn't highlighted in some cases

[whatyouhide]

Module names aren't highlighted if preceded by a pipe | character. This is the minimal example to reproduce the behaviour:

|List

and this is a screenshot of the behaviour in action:

[michalmuskala]

It also doesn't work correctly with &

[tonini]

Thanks for reporting

[tonini]

@syohex I guess you have a solution for this one? ;-)

[syohex]

I suppose elixir-mode should change syntax of such characters from symbol character to punctuation character as following patch. Any other characters than &, | ?

diff --git a/elixir-mode.el b/elixir-mode.el
index 77a0f6b..d4c0a3c 100644
--- a/elixir-mode.el
+++ b/elixir-mode.el
@@ -496,6 +496,10 @@ just return nil."
        #'elixir-syntax-propertize-function)
   (set (make-local-variable 'imenu-generic-expression)
        elixir-imenu-generic-expression)
+
+  (modify-syntax-entry ?| "." elixir-mode-syntax-table)
+  (modify-syntax-entry ?& "." elixir-mode-syntax-table)
+
   (smie-setup elixir-smie-grammar 'verbose-elixir-smie-rules
               :forward-token 'elixir-smie-forward-token
               :backward-token 'elixir-smie-backward-token))

Sreenshot with above patch is here.

[tonini]

That sounds like a good idea, would you like to make a PR?

Syohei YOSHIDA notifications@github.com schrieb am Mo., 19. Okt. 2015
16:53:

I suppose elixir-mode should change syntax of such characters from symbol
character to punctuation character as following patch. Any other characters
than &, | ?

diff --git a/elixir-mode.el b/elixir-mode.el
index 77a0f6b..d4c0a3c 100644--- a/elixir-mode.el+++ b/elixir-mode.el@@ -496,6 +496,10 @@ just return nil."
#'elixir-syntax-propertize-function)
(set (make-local-variable 'imenu-generic-expression)
elixir-imenu-generic-expression)++ (modify-syntax-entry ?| "." elixir-mode-syntax-table)+ (modify-syntax-entry ?& "." elixir-mode-syntax-table)+
(smie-setup elixir-smie-grammar 'verbose-elixir-smie-rules
:forward-token 'elixir-smie-forward-token
:backward-token 'elixir-smie-backward-token))

Sreenshot with above patch is here.

[image: fixed]
https://cloud.githubusercontent.com/assets/554281/10581202/6cf99d64-76bc-11e5-88f4-481db986a3fb.png

—
Reply to this email directly or view it on GitHub
#224 (comment)
.

[syohex]

👍

[tonini]

Thanks again for your help 👍