Raise on unsupported exprs #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
force-pushed
the
fix/raise-on-unsupported-literals
branch
from
8a2c116 to
c6ec889
Compare
josevalim
reviewed
Nov 30, 2021
Instead of the unfriendly "no case clause matching", this raises an error telling the user that the literal is not supported. This was already done by tds adapter.
v0idpwn
force-pushed
the
fix/raise-on-unsupported-literals
branch
from
c6ec889 to
b8573b8
Compare
josevalim
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the unfriendly "no case clause matching", this raises an
error telling the user that the literal is not supported. This was
already done by tds adapter.
Related to issue elixir-ecto/ecto#3784