Refactor & cleanup Luma Account tests & objects #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make the login method bulletproof so it tries to login only if needed 2. Use selectors to type in the data 3. Add state/region since it was missing 4. Add deleteAddress to be used in the account tests
1. Refactor account tests so login() gets called beforeEach 2. move Address create/delete to each test to have a test independency but still keep the tests focused on only what is being tested 3. Add intercept for checout part so wait is independent of the CI system 4. Remove all Log-out steps since they are not part of the tests
Refactor account tests
Contributor
Author
|
@peterjaap I modified the details for Luma and for some reason Hyva is failing. Since I don't have access to Hyva to fix it, I can't proceed here. Maybe the whole refactor doesn't make sense to you, so feel free to reject the whole thing. |
Collaborator
|
I don't think the luma failures are related to these changes. |
Contributor
Author
|
@Vinai I'm only seeing Hyva failures, not Luma. Am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the tests on a different CI with smaller resources, I've noticed a few issues around: