Skip to content

Conversation

@V02460
Copy link
Contributor

@V02460 V02460 commented Aug 6, 2025

Support passing multiple config files to register_new_matrix_user. Before, all but the last config file were silently ignored.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@V02460 V02460 requested a review from a team as a code owner August 6, 2025 09:22
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this, and sorry for the slow feedback on review.

This looks good to me, other than one small thing below!

@V02460 V02460 requested a review from anoadragon453 November 3, 2025 09:46
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for being so slow to get back to this. Requesting review is definitely the best way to get a PR back on to my radar. But occasional pings help too (and are welcome!).

One small remaining point below.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks!

@anoadragon453 anoadragon453 enabled auto-merge (squash) November 5, 2025 16:33
@anoadragon453 anoadragon453 merged commit dc7f01f into element-hq:develop Nov 10, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants