Add instructions for changing translated strings #6528
Conversation
Add instructions to the developer documentation for proper housekeeping of the translations when editing strings.
|
We have |
As per code review feedback, we should use the npm run scripts i18n and i18n-prune instead of editing the i18n JSON files directly.
Replace an inline, parenthetical note about possible failures of the `npm run` scripts with additional items in the Requirements section.
aidalgol
left a comment
aidalgol
left a comment
There was a problem hiding this comment.
The reason for this change is that now two sections in the document reference the npm i18n script.
|
Ah, it doesn't have a hyphen so actually it's Also, do you think it makes more sense to add the bit about editing after 'adding new strings'? Most of the time people will be adding strings I suspect, rather than editing existing ones. |
The `npm run` command `i18n-prune` is actually `prunei18n`.
Move "Editing existing strings" to after "Adding new strings".
I don't have a strong preference on the ordering. I have so far found myself editing more strings than adding new strings, |
2 participants
Add instructions to the developer documentation for proper housekeeping of the
translations when editing strings.
Signed-off-by: Aidan Gauland [email protected]