Aggregations: Handle failures when sending

[jryans]

(see current status below)

[jryans]

After chatting with @nadonomy about reactions / edits errors in general, we came up with:

• Use same e2e (!) icon to decorate messages with an error
  • Clicking on it reveals a context menu with any of:
    • Resend reactions
    • Resend edit
    • Encryption information
• Users will see the message status bar explaining the error (network, rate limited, unverified, etc.)
• Irrespective of what colours e2e uses (as its subject to change), unsent edit/reactions should always decorate red

Extracted from Editing / Reactions UX doc.

[jryans]

@nadonomy's plan above actually covers both reactions and edits, so I'll relabel the issue.

[lampholder]

The edits/reactions/redactions/local-echo work has raised a couple of issues that need rapid resolution:

• edits/reactions/redactions do not have a 'pending' state in the UX
• edits/reactions/redactions do not have a 'failure' state in the UX

This is a bigger problem for edits and redactions than it is for reactions (it is considered generally more important for a user to know if an edit or redaction has failed to persist than a reaction)

@nadonomy's proposal above is certainly worth exploring; in his absence though I'd like us to consider the simplest possible change we can make to convey the missing information. This is a proposal for what that might look like:

• pending actions:
  • represent pending edits as the new message text, but faded (color: #ddd; as per 'sending' message)
  • represent pending redactions as the original event body, but faded (this could work for images as well as regular messages)
  • just represent pending reactions with local echo
• failed actions:
  • represent failed edits as the new message text, but red (with the (edited) marker next to them) - it already works like this:
    
  • represent failed redactions as the redaction lozenge, but red?
  • represent failed reactions, or failed redactions of reactions with a red border around the reaction?

The ⋮ menu should then have the any necessary resends available as a context-menu option - resend edit, resend redaction, or resend reaction

We'd also need to modify the wording of the error message; something like:

Some of your messages, edits, reactions or redactions have not been sent.

Resend all or cancel all now. You can also select individual messages to resend or cancel pending actions.

[lampholder]

My motivation for the above was to see how far we could get stretching the existing 'faded == pending, red == failed' language to edit, reactions and redactions. At this stage in my thinking I am very much not convinced that stretching the existing language is the right approach - it could be that an 'error icon' based approach is clearer and simpler to implement.

[lampholder]

But I'm not sold on the wisdom of mutating the existing (!) from a 'there are encryption things you should know about' indicator to an iteractive 'there are errors on this message you need to do something about' component - at the very least this will be a tricky migration with many users not discovering the new functionality :\