Skip to content

"diff" syntax highlighting is inverted on dark theme #7921

@justin-sleep

Description

@justin-sleep

Description

On the dark theme, "+" lines are red, and "-" lines are green.

Steps to reproduce

Enter a diff into a syntax-highlighted block, like:

```diff
     public function testNonPublicPages()
     {
+        $this->get('/')->assertStatus(302);
         $this->get('/activate')->assertStatus(302);
         $this->get('/activation')->assertStatus(302);
-        $this->get('/activity')->assertStatus(302);
         $this->get('/exceeded')->assertStatus(302);
         $this->get('/home')->assertStatus(302);
-        $this->get('/routes')->assertStatus(302);
         $this->get('/themes')->assertStatus(302);
         $this->get('/users')->assertStatus(302);
         $this->get('/users/create')->assertStatus(302);
-        $this->get('/phpinfo')->assertStatus(302);
         $this->get('/profile/create')->assertStatus(302);
     }
```

Results

Light:
2018-12-19-16 50 46

Dark:
2018-12-19-16 50 59

Version information

  • Platform: Desktop

  • OS: Arch Linux

  • Version: 0.17.8

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ThemingP2S-MajorSeverely degrades major functionality or product features, with no satisfactory workaroundT-DefectZ-Community-PRIssue is solved by a community member's PR

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions