When the homeserver responds to /publicRooms with not-200, we retry straight away

[Half-Shot]

which leads to sluggish UI and my server getting harassed. I would have probably expected the directory to give up on anything that isn't a timeout.

Steps to reproduce

• Have a buggy homeserver that emits 500s when calling /publicRooms
• Click room directory
• A error prompt will open, but will flicker. If you open the developer tools, it will show lots of network requests.

Describe how what happens differs from what you expected.

Version information

• Platform: web desktop
  server, what version of riot-web?

• Version: 0.16.5

[Half-Shot]

This is caused by matrix-org/synapse#4039 on the synapse side.

[Half-Shot]

Did more debugging today, will also do it if it's not even online.

[jryans]

This appears to also be fixed by matrix-org/matrix-react-sdk#2834. I only see one request to /publicRooms now.