-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Labels
A-RepliesreplyreplyP1S-MajorSeverely degrades major functionality or product features, with no satisfactory workaroundSeverely degrades major functionality or product features, with no satisfactory workaroundT-Defect
Description
I built and tested the latest m.relates_to branches and hosted it on https://lant.uk/riot/new_replies
Things I tested:
- Replying to your own message ✅
- Replying to your own reply ✅
- Replying to a message from someone else ✅
- Replying to a reply from someone else ✅
- Replying to an emote ✅
- Replying to a picture ✅
- Replying to a file ✅
- Not being able to reply with an emote ✅
- Not being able to reply with a file
⚠️ - Replying on a narrow screen
⚠️ - Replying with a single emoji ✅
- Replying in an E2E room when there are unknown devices in the room
⚠️ - Representation on today's /app ✅ (In reply to link links to the original message)
- Representation over IRC bridge ✅ (reply is rendered sensibly)
In conclusion, for the most part it's great and nothing was show-stoppingly broken, but the
Issues Identified
- P1 Reply UX slow to disappear - The replies UX was sometimes slow to disappear (taking ~a second to disappear after the reply has been sent)
- P2 Replying in an E2E room when there are unknown devices in the room - The current experience is:
- initiate reply
- type message
- click send
- receive 'unknown devices' prompt (which shows the reply as a red pending message, rather than a reply)
- click 'send message'
- message rendered to the timeline as a message
- a few seconds later, the message appears (correctly) as a reply
- P2 Replying on a narrow screen - we get a return of the one-character-wide super tallness:
- P3 Not being able to reply with a file - If you open the reply function then upload a file, the file uploads behind the reply UX (and not as a reply). It is a known limitation of the current impl that we can't reply with a file, but the UX doesn't make that obvious (in the way that it does, say, for our not being able to reply with an emote).
- P3 Replying with a single emoji - it renders in the small style rather than the usual large style of a single... emojus
Metadata
Metadata
Assignees
Labels
A-RepliesreplyreplyP1S-MajorSeverely degrades major functionality or product features, with no satisfactory workaroundSeverely degrades major functionality or product features, with no satisfactory workaroundT-Defect