Upgrade path to React 16

[lukebarnard1]

This afternoon, I took a random detour to get Riot working with React 16, for the sake of investigating how difficult this would be. I succeeded, but obviously the diff is huge, so we might not want to do this "right now".

I did not manage to get the react-sdk tests working, primarily because matrix-react-test-utils needs similar treatment (being made compatible with React 16).

Steps to upgrade riot-web, matrix-react-sdk and matrix-react-test-utils:

• Update various npm dependencies to most recent versions:
  • draft-js-export-html
  • draft-js-export-markdown
  • react
  • react-dom
  • react-gemini-scrollbar
• Apply react-codemod JSCodeshifts on /src and /test
  • React-PropTypes-to-prop-types
    • will fail on trailing commas at the end of prop types
    • and where there is more than one "React.PropTypes" on a single line
  • class
    • Might render the box it's running on totally useless for a few minutes...
• s/react-addons-test-utils/react-dom\/test-utils/
• Fix cases where the React context API has changed(?)

[lampholder]

OOI was there an inspiration for this detour other than generally keeping framework use up to date?

[lukebarnard1]

My inspiration was primarily the number of times I've stared blankly at the logs when there's a bug that cause React to go wibbly and useless, requiring a refresh. This has been fixed in 16.

[akihikodaki]

I managed Riot work on React 16:
https://github.com/akihikodaki/riot-web/tree/react-16

Pull requests of dependent changes are open.

[lukebarnard1]

Assigning myself just to remind me that I want this to happen 😄 thanks @akihikodaki for doing all of this