Code blocks without syntax highlighting illegible on dark theme

[turt2live]

Description

As per matrix-org/matrix-react-sdk#1074 (comment) and matrix-org/matrix-react-sdk#1074 (comment) the block is completely illegible. Toggling the 'guess language' setting does fix this.

Log: not sent

Version information

• Platform: web (in-browser)
• Browser: Chrome 58
• OS: Windows 10
• URL: riot.im/develop

[kegsay]

This is infuriating for me. When did this break? I'm fairly sure it wasn't always this bad.

[t3chguy]

@kegsay Syntax highlighting used to be set to auto so it made some dash attempt which at least applied some colour, now syntax highlighting is explicit only since matrix-org/matrix-react-sdk#1074

[turt2live]

@kegsay a recent PR (matrix-org/matrix-react-sdk#1074) removed syntax highlighting for code blocks. There's now a setting to turn on the highlight-guessing code

[t3chguy]

@turt2live SNIPED

[kegsay]

I'd rather have random words like this and for in weird colours along with a legible default colour than what we have currently. The old form was annoying but this form is unusable.

[sbts]

I have to agree with @kegsay
Even worse is the fact that we regularly explicitly declare a type of plain.
That was working until a day or so ago, and now it's broken, even with the config setting flipped.

If plain is broken, we need the riot code to be specifically overriding it to force guessing until plain can be fixed!!!!!!

Probably more important until then, the default setting for the config option should be enabled if dark theme is enabled, and probably even if it's not

[ara4n]

i believe e7ba618 fixes this. it was a bug, plain and simple, irrespective of the fact that removing autosyntaxhighlighting exposed it.