Confusing error: "This room is unfederated" when inviting someone on the same server to an unfederated room without perms

[jeffcasavant]

Steps to reproduce

1. Create a room that's unfederated & select a user on the same server as the room
2. As a separate user without permission to invite to the room, try to invite the user
3. Observe the error message says that the room is unfederated
4. Add the permission to invite
5. Try again, and observe success, indicating it's not an unfederated room issue

Outcome

What did you expect?

The error should read "You do not have permission to invite to this room"

What happened instead?

The error read "This room is unfederated. You cannot invite people from external servers."

Operating system

macOS

Browser information

Ferdium v6.6.0 with Chrome 118.0.5993.89

URL for webapp

https://chat.casavant.org

Application version

Element version: 1.11.51 Crypto version: Olm 3.2.15

Homeserver

matrix.casavant.org / synapse v1.97.0

Will you send logs?

Yes

[jeffcasavant]

[t3chguy]

I don't see how this error is possible if the room is federated. Can you share the contents of the m.room.create event?

Will you send logs?
Yes

Not seeing any logs from you yet

[jeffcasavant]

It's been like 2 minutes. Gimme just a sec.

[jeffcasavant]

I'm getting a CORS error when uploading them:

[jeffcasavant]

Additionally though - that code path you're showing seems like it just covers when I'm trying to invite someone not server-local. Do you think this error could be shown if

• The room is unfederated
• The invitee is server-local
• The inviter doesn't have the requisite perms?

[jeffcasavant]

Apologies, my room isn't federated, that's my mistake. I'll update the issue.

{
  "type": "m.room.create",
  "sender": "@tom:casavant.org",
  "content": {
    "m.federate": false,
    "room_version": "9",
    "creator": "@tom:casavant.org"
  },
  "state_key": "",
  "origin_server_ts": 1662756919960,
  "unsigned": {
    "age": 39121166076
  },
  "event_id": "$W6QgVrJg4UNn3TiFFm5gmK2mGh2wlemEjFdBbd7Z0eA",
  "room_id": "!FoRoOrRYNjZoJABmaq:casavant.org"
}

[t3chguy]

The invite button should be disabled so you shouldn't even be able to try to invite someone if you don't have perms

[jeffcasavant]

I was using the /invite command.

[t3chguy]

The command should get disabled when you lack permissions

[jeffcasavant]

Maybe that's the bug then?