-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
A-Developer-ExperienceA-TimelineT-DefectZ-Flaky-TestA test is raising false alarmsA test is raising false alarms
Description
Steps to reproduce
This might be an upstream issue, but it seems that Percy tests do not capture movement of collapse link button on GELS (generic event list summary), introduced with matrix-org/matrix-react-sdk#10211.
Here are the Percy results which seem to have the issue (please check it by toggling original and new):
- Expanded GELS and with placeholder of deleted message
- Expanded GELS and with emote and placeholder of deleted message
- Expanded GELS and messages on IRC layout
- Event line with inline start margin on IRC layout
Those snapshots are built on this PR: matrix-org/matrix-react-sdk#10189
Outcome
What did you expect?
The horizontal row where collapse link button exists should be highlighted, as its movement (by matrix-org/matrix-react-sdk#10211) is exactly what caused the snapshot changes.
What happened instead?
Percy did not highlight the row. It highlights other parts instead, which I think is quite confusing to those who did not work on the change.
Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
No response
Homeserver
No response
Will you send logs?
No
Metadata
Metadata
Assignees
Labels
A-Developer-ExperienceA-TimelineT-DefectZ-Flaky-TestA test is raising false alarmsA test is raising false alarms