Login on a new account unable to verify device

[germain-gg]

Steps to reproduce

1. Create a new account
2. Log in
3. Go to a new browser and login that same account

Outcome

What happened instead?

I have the Unable to verify this device E2E dialog asking me to proceed with a "reset".

What did you expect?

To be logged in
I have 0 DMs in my new account, and have not setup anything related to encryption. That step should be skipped entirely

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

[duxovni]

I'm noticing now that when I create a new account on my local containerized test server, the newly-created device (at least as returned by MatrixClient.getStoredDevice) doesn't have a signature from the SSK, which leads Element to conclude that the device is unverified and therefore I have no verified devices, which would cause this error. I'm not sure why that signature is missing, and wasn't able to reproduce it on develop.element.io; I've been trying to figure out if it's somehow caused by accessing my local test Element and test Synapse over HTTP rather than HTTPS, but haven't found any solid clues yet.

[duxovni]

On further inspection, it looks like the broken version of Element is attempting to upload its device signatures to the homeserver before it's finished uploading its device signing keys, which leads to the upload getting rejected, so those signatures are missing when the device keys are queried later. I'll continue investigating why that's happening.

[duxovni]

Tracked it down to matrix-org/matrix-react-sdk#8457; there's some typing confusion going on, and in the contexts that matter here, makeRequest really is an async function and does need to be awaited. I'll put together a PR.