Labels not displaying correctly

[lupa18]

Steps to reproduce

1. I began an individual call
2. Click share screen button

Outcome

What did you expect?

See correct texts

What happened instead?

"missing translation" appears next to actual text

Operating system

Linux

Application version

Versión de Element: 1.9.8
Versión de Olm: 3.2.8

How did you install the app?

https://element.io/get-started (apt)

Homeserver

matrix.org

Will you send logs?

No

[kittykat]

Duplicate of #9422

Thank you for taking the time to report this issue. I'm going to close this report in favour of the old one. Please follow that one if you would like updates on the progress.

[SimonBrandner]

Hmm, I don't think this is the same issue, just a feeling now, will investigate

[MTRNord]

Hmm, I don't think this is the same issue, just a feeling now, will investigate

Knowing the old issue, I agree that this is different. There was a recent fallback related PR in the react-sdk "recently" which is my guess on what is causing it since this is happening also for things that had no code changes for 6 months or more.

(My guess is matrix-org/matrix-react-sdk#7323 though I am not sure what exactly in it may cause this)

Most likely the change from https://github.com/matrix-org/matrix-react-sdk/pull/7323/files#diff-0733568a0dbb658491a8eb24c5646711c77c32f86701b3212ac5a54b014c683eL42 to https://github.com/matrix-org/matrix-react-sdk/pull/7323/files#diff-0733568a0dbb658491a8eb24c5646711c77c32f86701b3212ac5a54b014c683eR76-R92 likely caused this. Since this changed, the complete way fallback languages are handled.

[MTRNord]

Actually looking more at this the exact regression seems to be that https://github.com/matrix-org/matrix-react-sdk/pull/7323/files#diff-0733568a0dbb658491a8eb24c5646711c77c32f86701b3212ac5a54b014c683eL101-L105 is missing now. At least, I don't see how it now is handled?

The old code handled that by explicitly requesting it by overwriting the language of the specific string. However, the new code sets the fallback language. If the comment on the old code can be trusted, the new code works as long as there are no plurals. So in short the old if is still needed as counterpart is not doing fallback for plural things and there for we can't rely on the fallback language option.

[kittykat]

I've seen it on app.element.io in Firefox now:

[kittykat]

Also nightly on Linux: