macOS hotkey for Go to Home View is surprising, should use Command instead of Control

[lilyball]

Steps to reproduce

1. Run the app on macOS
2. Press ⇧⌘H

Outcome

What did you expect?

It should have gone to the Home View

What happened instead?

Nothing at all, because the shortcut is actually ⌃⇧H

The other shortcuts use the Command key as appropriate, this is the only one that uses Control inappropriately. The other hotkeys using Control are modifiers on the arrow keys, which is fine.

Operating system

macOS

Application version

Version 1.9.5

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

[kittykat]

Yes, this should be resolved by updating the shortcut to ⇧⌘H - issue is ready for development 👍

[aj-ya]

Hey @kittykat ! I would like to work on this issue. Could you help me get started.

[SimonBrandner]

Hey @kittykat ! I would like to work on this issue. Could you help me get started.

The relevant files are https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/accessibility/KeyboardShortcuts.ts and https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/KeyBindingsDefaults.ts. Be sure to visit https://matrix.to/#/#element-dev:matrix.org if you need more guidance!

[aj-ya]

Hey! @SimonBrandner Thanks for assigning me to this issue! After going through those files and the issue, I believe I have to bind the 'Go to Home' view to the following key combinations.
on Mac : SHIFT + ⌘ + H ( presently CTRL+SHIFT+H )
on PC: CTRL + ALT + H ( presently CTRL+ALT+H )
Please give me a thumbs up, if I'm right!

[SimonBrandner]

Hey! @SimonBrandner Thanks for assigning me to this issue! After going through those files and the issue, I believe I have to bind the 'Go to Home' view to the following key combinations. on Mac : SHIFT + ⌘ + H ( presently CTRL+SHIFT+H ) on PC: CTRL + ALT + H ( presently CTRL+ALT+H ) Please give me a thumbs up, if I'm right!

Sounds good 👍